Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce p50, p90 and p99 latency metrics for graphs and subgraphs #1710

Conversation

wilsonrivera
Copy link
Contributor

@wilsonrivera wilsonrivera commented Mar 19, 2025

Motivation and Context

As a User, I want to see P50, P90 and P99 latencies of my operations to understand the average operation latency of my system.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.
analytics.mov

Graph metrics
graph

Subgraph metrics
subgraph

Inactive legends
image

Copy link

github-actions bot commented Mar 19, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-9c1275dc194f990cb25c97cec58cda1772455b37

@wilsonrivera wilsonrivera changed the title feat: introduce p50, p90 and p99 latency metrics for graphs and… feat: introduce p50, p90 and p99 latency metrics for graphs and subgraphs Mar 19, 2025
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilsonrivera wilsonrivera requested a review from StarpTech March 24, 2025 19:21
…cosmo-analytics-dashboard

# Conflicts:
#	connect-go/gen/proto/wg/cosmo/platform/v1/platform.pb.go
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilsonrivera wilsonrivera merged commit 1c55ed5 into main Mar 24, 2025
27 checks passed
@wilsonrivera wilsonrivera deleted the wilson/eng-6056-show-p99-p90-p50-latency-in-cosmo-analytics-dashboard branch March 24, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants