Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to DummyCaster package for vec3 origins #441

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

thecadorn
Copy link
Contributor

Following conversation in the discord, support vec3 origins. Keep support for vec2 origins and convert them internally.

@Frotty
Copy link
Member

Frotty commented Feb 6, 2025

Thanks for the PR. However, it seems that you are not using the z component of origin anywhere?
In line 86 it's still just doing setXY.

@thecadorn
Copy link
Contributor Author

Oh no, I was definitely rushing through this. Thanks for catching it!

Updated with setXYZ. It looks like this one sets the position relative to the terrain height, whereas setXYZReal sets an absolute position.

@Frotty
Copy link
Member

Frotty commented Feb 7, 2025

Thanks.

Updated with setXYZ. It looks like this one sets the position relative to the terrain height, whereas setXYZReal sets an absolute position.

Yep, should be the correct choice when doing dummy casts for air units.

@Frotty Frotty merged commit 83ee4c2 into wurstscript:master Feb 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants