Allow ObanTelemetry to check if it needs to report errors #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MvanDiemen
force-pushed
the
reportable_oban_telemetry
branch
from
a489029 to
8ce7aaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all errors in Oban always need to be reported as errors. If Oban is setup to have multiple attempts with the potential of reaching timeouts or rate limits these are expected errors and not reportable.
Oban has an example on how to deal with expected failures see documentation which is the inspiration of adding
reportable?/1as a check.As
Tracing.ObanWorkeris not in the application to decide this, allowing each Oban worker module to specifyreportable?/1will give back the decisiveness to the developer to decide on a worker by worker basis.