This repository has been archived by the owner on Jan 25, 2019. It is now read-only.
Add sorting based on custom attributes #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 14, 2016 11:03
Merge pull request wvteijlingen#130 from Ybrin/master
Merge newest version into Ybrin/master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the JSONAPI documentation:
it is not required that sort fields are a valid resource field. I added
addCustomAscendingOrderandaddCustomDescendingOrderwhich don't fail if the provided attribute is not a valid field.I also changed the router so that it does not fail if a custom value was provided.
I think this should be added to Spine as JSONAPI does not restrict us to have custom sort fields.