This repository has been archived by the owner on Jan 25, 2019. It is now read-only.
Swift 4 Updates #196
Open
Swift 4 Updates #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on success syntax
… optional values in Strings.
hhgz9527
reviewed
Nov 17, 2017
| @@ -134,7 +134,8 @@ struct ValueFormatterRegistry { | |||
| /// it will return an absolute URL, relative to the baseURL. | |||
| private struct URLValueFormatter: ValueFormatter { | |||
| func unformatValue(_ value: String, forAttribute attribute: URLAttribute) -> URL { | |||
| return URL(string: value, relativeTo: attribute.baseURL as URL?)! | |||
| guard let url = URL(string: value, relativeTo: attribute.baseURL as URL?) else { return URL(string: "www.pixhug.com")! } | |||
There was a problem hiding this comment.
My bad, this leaked inside by accident
hhgz9527
reviewed
Nov 17, 2017
| @@ -53,7 +53,7 @@ class FindAllTests: SpineTests { | |||
| } | |||
|
|
|||
| waitForExpectations(timeout: 10) { error in | |||
| XCTAssertNil(error, "\(error)") | |||
| XCTAssertNil(error, "\(String(describing: error))") | |||
There was a problem hiding this comment.
maybe you can remove "\()", just use String(describing: error)
There was a problem hiding this comment.
Yeah, pretty sure that'll work as well. There are quite a few of these String(describing:) changes that I just changed via the auto migrator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the framework to Swift 4, and clears all warnings provided from Xcode 9.