Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial prototype to refactor custom_seasons API with Xarray SeasonGrouper() API [WIP] #715

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Initial prototype to refactor custom_seasons API with Xarray SeasonGrouper() API [WIP] #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7716efc
Add baseline unit tests
tomvothecoder Mar 1, 2023
ade02ba
Add support for shifting months in seasons spanning calendar year
tomvothecoder Mar 3, 2023
2a87cf0
Add explaination of code for spanning months
tomvothecoder Mar 3, 2023
6b4ec65
Replace `drop_incomplete_djf` with `drop_incomplete_seasons`
tomvothecoder Mar 3, 2023
fbad335
Fix `_drop_incomplete_seasons()` adding dims to variables
tomvothecoder Mar 7, 2023
4a896ba
Add deprecation warning for "drop_incomplete_djf"
tomvothecoder Apr 4, 2024
9f496e5
Fix tests
tomvothecoder Apr 4, 2024
7cb6910
Add test to cover missing line in `_drop_incomplete_season`
tomvothecoder Apr 4, 2024
1cf4364
Add clear error message when no complete seasons are found
tomvothecoder Jul 30, 2024
a050884
Update deprecation version for `drop_incomplete_djf`
tomvothecoder Jul 30, 2024
5ace7a8
Update static time dim ref to CF interpreted dim key
tomvothecoder Aug 1, 2024
25e31f7
Add `drop_incomplete_djf` back
tomvothecoder Oct 14, 2024
2b47972
Move deprecation warning to inside DJF conditional
tomvothecoder Oct 14, 2024
05496ed
Update comment about .where concatenating time din
tomvothecoder Oct 23, 2024
0b6852f
Refactor logic for shifting months to use Xarray instead of Pandas
tomvothecoder Oct 24, 2024
8d156c2
Add todo comments
tomvothecoder Nov 12, 2024
2e736ca
Initial prototype using Xarray SeasonGrouper`
tomvothecoder Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading