Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PaymentModule UUPSUpgradeable compatible #32

Merged
merged 14 commits into from
Nov 22, 2024

Conversation

gabrielstoica
Copy link
Collaborator

@gabrielstoica gabrielstoica commented Nov 21, 2024

Breaking changes

  • PaymentModule was refactored to support UUPS upgradeability based on the OpenZeppelin UUPSUpgradeable implementation with ERC-7201;
  • Streams are now non-transferable by default due to the new architecture;
  • _withdrawMaxAndTransferStream method has been removed;

Other changes

  • cancelStream public method has been added on the StreamManager implementation;
  • Tests updated accordingly;
  • Documentation extended and refined;

@gabrielstoica gabrielstoica requested a review from V1d0r November 22, 2024 07:24
Copy link
Contributor

@V1d0r V1d0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. UUPSUpgradeable gives the flexibility to enhance and change the PaymentModule later as the product evolves. Particularly around payments streams. transferability and NFTs that are still unexplored fully!

@gabrielstoica gabrielstoica merged commit 1a5e725 into main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants