feat: support 2-layered scatter plot #100
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add demonstrations of how users can leverage Maidr to create double-layered scatterplots.
Type of Change
Checklist
Pull Request
Description
This PR aims to include examples of how double-layered scatter plots can be created using maidr
Related Issues
#85
Changes Made
This is a draft PR that has the new 2-layered scatterplot example. As the example is still in development phase, I have included the html generation as part of the example. Additionally, the
_inject_plot
method has been modified to accept a flag calledhtml
. If set toTrue
, the_inject_plot
method will return the bare html for the plot. The default value isFalse
and if the flag is set toFalse
, the iframe element containing the plot will be returned.Screenshots (if applicable)
Checklist
ManualTestingProcess.md
, and all tests related to this pull request pass.Additional Notes
I am encountering the following issues by leveraging the current py-binder and upstream dependancies.
I have this error showing up on DevTools when the html is validated:
Whilst the secondary plot toggle seems to be an issue on the upstream repository, I would like to know if any additional changes should be done on the py-binder to activate highlighting of scatterplot components.