Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the settings_data injection script temporarily #120

Closed
wants to merge 2 commits into from

Conversation

dakshpokar
Copy link
Collaborator

@dakshpokar dakshpokar commented Oct 9, 2024

Description

This is a temporary fix for the issue #119. This removes the settings_data injection script that is included with every iframe onload event in pymaidr.

Type of Change

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Pull Request

Changes Made

  1. Removed the Environment.initialize_llm_secrets() function from the onload event in iframe

@dakshpokar dakshpokar marked this pull request as ready for review October 9, 2024 20:33
@dakshpokar dakshpokar requested a review from jooyoungseo October 9, 2024 20:33
Copy link
Member

@jooyoungseo jooyoungseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR, but not going to merge until you implement the action item 2 in a separate PR. Please address the tempfile load. I will merge them together.

@jooyoungseo
Copy link
Member

This patch has already been merged.

@jooyoungseo jooyoungseo closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants