Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inherited group member api #1958

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

nanjingfm
Copy link
Contributor

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions, rest looks good 👍🏻

group_members.go Outdated Show resolved Hide resolved
group_members_test.go Outdated Show resolved Hide resolved
group_members_test.go Outdated Show resolved Hide resolved
@an0rak-dev
Copy link

Hi 👋🏻
Thanks for your work ! I'm quite interested with this endpoint ! Do you have any news about this ? 👀

@nanjingfm
Copy link
Contributor Author

Hi @svanharmelen ,

Thank you for the suggestions! I have updated the PR based on your feedback. Could you please review the changes?

Thanks again!

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @nanjingfm 👍🏻

@svanharmelen svanharmelen merged commit 138b042 into xanzy:main Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants