-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA-142451: Unit tests #211
base: master
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
Coverage increased (+0.44%) when pulling 5a0977c8df4f0bc2601f188aa76791ec6e20c061 on fquesnel:unittestmaster into 66c89ea on xapi-project:master. |
Coverage increased (+0.47%) when pulling 72017f641f9a542a62bff0e1c6665f62fe5f8d50 on fquesnel:unittestmaster into 66c89ea on xapi-project:master. |
Covering changes related to CA-142451. Signed-off-by: Flavien Quesnel <[email protected]>
72017f6
to
ab75df0
Compare
Looks good to me, OK to merge! |
I can merge but the situation has become a little bit confused. This are the unit tests for #210. #210 has been merged and then ported in creedence with #213 |
@germanop Yes, I think we left with cherry-picking the xs64bit change to master. I agree that it is suboptimal. I can do the cherry picking to master, just let me know. So I guess let's close this PR, and just cherry-pick 2ddae13 The other thing we can do is to close this PR, and care about master branch later. |
Nooooo, do not close it!!! Please let's avoid creating too many PRs for the same reason |
ok. |
Covering changes related to CA-142451.
Signed-off-by: Flavien Quesnel [email protected]