Skip to content

Commit

Permalink
CA-393507: Default cluster_stack value
Browse files Browse the repository at this point in the history
Add a `@default` attribute to the `cluster_stack` field in the cluster
config. This field was introduced in #c1bd0e31a but causes RPU to fail
since it is not optional, and while xapi-clusterd was unmarshalling an
old db (which contains cluster config), it cannot find this field, and
throws an exception.

Adding `@default` can make the rpc library to fill this field in when it
is missing, solving the above problem.

Signed-off-by: Vincent Liu <[email protected]>
  • Loading branch information
Vincent-lau authored and minglumlu committed Jun 6, 2024
1 parent d127cdd commit 58dad98
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ocaml/xapi-idl/cluster/cluster_interface.ml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ type cluster_config = {
; config_version: int64
; cluster_token_timeout_ms: int64
; cluster_token_coefficient_ms: int64
; cluster_stack: Cluster_stack.t
; cluster_stack: Cluster_stack.t [@default Corosync2]
}
[@@deriving rpcty]

Expand Down

0 comments on commit 58dad98

Please sign in to comment.