Skip to content

Commit

Permalink
database: do not log when a field is dropped when loading from db_xml
Browse files Browse the repository at this point in the history
It causes logspam and hasn't been useful in the years it's been present.
Lowering it to a debug statement would still cause it to be logged, so drop the
message completely instead.

Signed-off-by: Pau Ruiz Safont <[email protected]>
  • Loading branch information
psafont committed Jan 8, 2025
1 parent 38a8f98 commit 77258a4
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions ocaml/database/db_xml.ml
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,9 @@ module From = struct
D.warn "no lifetime information about %s.%s, ignoring" tblname k ;
false
in
if do_not_load then (
D.info
{|dropping column "%s.%s": it has been removed from the datamodel|}
tblname k ;
if do_not_load then
row
) else
else
let column_schema = Schema.Table.find k table_schema in
let value =
Schema.Value.unmarshal column_schema.Schema.Column.ty
Expand Down

0 comments on commit 77258a4

Please sign in to comment.