[ASAP] CP-47431: Use un-patched Json.NET in C# SDK and package SDK in releases. Update PS SDK to use NuGet reference to XenServer.NET #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Feb 6, 2024
psafont
added a commit
to psafont/xen-api
that referenced
this pull request
Feb 6, 2024
It does not support linting actions, which blocks reusing code in github actions. On top of that it hasn't been updated in months. There's a PR to add actions to it since october. Since this is blocking xapi-project#5433, remove it Signed-off-by: Pau Ruiz Safont <[email protected]>
Merged
danilo-delbusso
force-pushed
the
dev/drop-json.net-patches
branch
from
aaa835b to
f7ae90e
Compare
|
rebased on master and added a commit based on PR comments however, I am putting this one into draft since I noticed we need changes to the PS SDK |
danilo-delbusso
force-pushed
the
dev/drop-json.net-patches
branch
from
f7ae90e to
82a19bb
Compare
danilo-delbusso
changed the title
psafont
reviewed
Feb 8, 2024
kc284
changed the title
danilo-delbusso
added
needs updating
needs answering
and removed
updated
needs updating
needs answering
labels
… in C# SDK Also: - Rename `README.dist` and `README-NuGet.dist` to `README.md` and `README-NuGet.md` - Change content of aforementioned READMEs to use markdown - Remove mentions of patched Json.NET library - Update copyright notice year - Do not add `.txt` extension to `LICENSE` file Signed-off-by: Danilo Del Busso <[email protected]>
Signed-off-by: Danilo Del Busso <[email protected]>
danilo-delbusso
force-pushed
the
dev/drop-json.net-patches
branch
from
82a19bb to
7e6a66c
Compare
|
Rebased on |
|
spotted an issue and had to force-push a couple times. see this diff for the latest changes, to make it easier to review them: |
kc284
requested changes
Feb 16, 2024
ocaml/sdk-gen/csharp/templates/FriendlyErrorNames.Designer.mustache
Outdated
Show resolved
Hide resolved
Enables building without the use of `ResGen.exe` Signed-off-by: Danilo Del Busso <[email protected]>
danilo-delbusso
force-pushed
the
dev/drop-json.net-patches
branch
from
ed1cafe to
34572ff
Compare
Also: - Update copyright notices - Update `README` files to use markdown - Add `.gitignore` file - Drop extension from `LICENSE.txt` - Add `.sln` file since it's needed for NuGet usage in VS22 - Add .NET 8.0 to list of target frameworks for the SDK project - Ensure all DLLs are placed in `bin/` when running `dotnet build`. Without `CopyLocalLockFileAssemblies = true` this is not the case for .NET builds. Signed-off-by: Danilo Del Busso <[email protected]>
Makes use of new composite action that sets up a XenAPI environment in a Ubuntu node. Signed-off-by: Danilo Del Busso <[email protected]>
Signed-off-by: Danilo Del Busso <[email protected]>
danilo-delbusso
force-pushed
the
dev/drop-json.net-patches
branch
from
3cf71f9 to
15e55ed
Compare
psafont
approved these changes
Mar 5, 2024
CitrixChris
approved these changes
Mar 5, 2024
kc284
approved these changes
Mar 5, 2024
|
@danilo-delbusso I noticed the "don't merge" label was added today, is there anything new blocking this PR? |
Nope, just wanted to make sure you had a chance to review it before it was merged :) |
psafont
reviewed
Mar 6, 2024
danilo-delbusso
force-pushed
the
dev/drop-json.net-patches
branch
from
15e55ed to
361e342
Compare
Signed-off-by: Danilo Del Busso <[email protected]>
Signed-off-by: Danilo Del Busso <[email protected]> damnit
Signed-off-by: Danilo Del Busso <[email protected]>
- Upload PS DLLs as part of SDK artefacts - Use one call to upload all artefacts in release.yml Signed-off-by: Danilo Del Busso <[email protected]>
Other binaries are of the form `SDK_Binaries_XYZ` Signed-off-by: Danilo Del Busso <[email protected]>
danilo-delbusso
force-pushed
the
dev/drop-json.net-patches
branch
from
361e342 to
227a1d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains two main changes:
To achieve this I split up the intialisation of a XenAPI environment in a separate composite action so it can be reused