CA-394444: hard_shutdown stuck behind a pending shutdown
#5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ``shutdown` to the list of operation that `hard_shutdown` can cancel. Currently, ``shutdown` is missing from the list of operation that `hard_shutdown` needs to cancel. Signed-off-by: Gabriel Buica <[email protected]>
|
Small typo in the commit message "disply", looks good otherwise, can you fix that and force push? |
Adds ``shutdown` to `vm_operation_table`. `VM.shutdown` operations were displayed as `(unknown operation)`. This should display the operation correctly in logs and during `xe task-list`. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/CA-394444
branch
from
4a1ab0f to
5c906eb
Compare
psafont
approved these changes
Jun 18, 2024
robhoes
approved these changes
Jun 18, 2024
|
BVT 199847 passed |
edwintorok
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM.hard_shutdowndoes not cancelVM.shutdownoperations.In the case of losing the session during a failed
VM.shutdown, we cannot recover withVM.hard_shutdownas it is not in the list of operations that are to be cancelled.These results in VM hanging until the requests time out.
Moreover,
VM.shutdowmis missing from thevm_operation_tableresulting in it being incorrectly displayed as(unknown operation).