XSI-1773 clean up swtpm service files #6193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
force-pushed
the
private/christianlin/XSI-1773
branch
from
cace65f to
3e2f3f4
Compare
psafont
approved these changes
Dec 20, 2024
|
This might not be enough for all cases, but probably covers most of them. Do we need to clean up before creating a service? |
robhoes
reviewed
Dec 20, 2024
ocaml/xenopsd/xc/service.ml
Outdated
| @@ -619,15 +619,14 @@ module SystemdDaemonMgmt (D : DAEMONPIDPATH) = struct | |||
| match (of_domid domid, is_running ~xs domid) with | |||
There was a problem hiding this comment.
This (existing code) is makes some unnecessary calls, as is_running also calls of_domid internally. And now we don't even care about the result of is_running in the systemd case. So better would be to drop is_running from the match and call Compat.is_running ~xs domid in the None case below.
robhoes
approved these changes
Dec 20, 2024
We have seen swtpm systemd service files not being removed. We now call Fe_systemctl.stop even when the servive is potentially not running to ensure clean up is happening regardless. Signed-off-by: Christian Lindig <[email protected]>
lindig
force-pushed
the
private/christianlin/XSI-1773
branch
from
3e2f3f4 to
3d394e0
Compare
robhoes
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen swtpm systemd service files not being removed. We now make Fe_systemctl.stop callable when the servive is potentially not running to ensure clean up is happening regardless.