Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CP-52245: Temp disable repo_gpgcheck when syncing from remote_pool repo" #6196

Merged

Conversation

gangj
Copy link
Contributor

@gangj gangj commented Dec 26, 2024

This reverts commit c710e8f.

…_pool repo"

This reverts commit c710e8f.

Signed-off-by: Gang Ji <gang.ji@cloud.com>
@gangj gangj force-pushed the private/gangj/CP-52245 branch from 460fdbf to 325e243 Compare December 26, 2024 06:15
@psafont
Copy link
Member

psafont commented Dec 27, 2024

I'm missing the context for the revert, could you explain the reason in the commit? thanks

@gangj
Copy link
Contributor Author

gangj commented Jan 2, 2025

I'm missing the context for the revert, could you explain the reason in the commit? thanks

Sure, c710e8f temporarily disabled repo_gpgcheck for remote_pool type of repository, it is because we(uses yum util: reposync) have not synced "asc" type of file from CDN or update bundle to the local cached yum repo in the coordinator, when later the coordinator become a remote_pool repo, it is that "asc" file: repo_gpgcheck was checked upon when syncing updating from the remote_pool repo.
As now we have patched "yum util" to make "reposync" also have "asc" file synced, we can re-enable repo_gpgcheck for remote_pool repo.

@gangj gangj merged commit b3e1ec1 into xapi-project:feature/easier-pool-join Jan 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants