CA-404013: do not relock the mutex when backing up rrds #6215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The point of using try_lock is to not get the thread suspended while trying to hold the mutex. Releasing it and calling `lock` may suspend the thread and defeats the purpose of using try_lock in the first place. Reorganise the sequence to read and copy all the rrds first while under the locked mutex, release it, and then archive the copies. Signed-off-by: Pau Ruiz Safont <[email protected]>
It causes logspam and hasn't been useful in the years it's been present. Lowering it to a debug statement would still cause it to be logged, so drop the message completely instead. Signed-off-by: Pau Ruiz Safont <[email protected]>
snwoods
approved these changes
Jan 8, 2025
|
I suggest to merge this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of using try_lock is to not get lock while trying to hold the mutex.
Releasing it and blocking to lock it defeats the purpose of using try_lock.
Reorganise the sequence to read and copy all the rrds first while under the
locked mutex, release it, and then archive the copies.
This doesn't fix CA-404013 directly, so this can wait until the release is cut. I'm opening otherwise I'll forget to open it when things are unlocked.
I've run the smoke and validation tests, as well as checking that the rrd files in the bugtools are well formed for hosts and vms (they are created suing this function)