Skip to content

Commit

Permalink
Don't add series for missing row count (#474)
Browse files Browse the repository at this point in the history
Some bechmarks don't include a series for all row count values. Don't
add a chart if there is no data for the row count.

Fixes an issue with the `ReadSchema` benchmark where we see multiple row
count values even though we only populate one of them:

<img width="828" alt="Screenshot 2024-11-20 at 12 33 13"
src="https://github.com/user-attachments/assets/f129ebb3-46ae-43bc-864a-7dc404ff7a1c">
  • Loading branch information
ryanslade authored Nov 20, 2024
1 parent 481f1c6 commit 96e50f9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions dev/benchmark-results/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@ func generateCharts(reports []BenchmarkReports) []*charts.Line {

for _, rowCount := range sortedRowCounts {
s := series[rowCount]
if len(s) == 0 {
continue
}

name := fmt.Sprintf("%d", rowCount)
data := make([]opts.LineData, len(series[rowCount]))
Expand Down

0 comments on commit 96e50f9

Please sign in to comment.