-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist benchmark results in CI #461
Conversation
dfca335
to
27a1b3a
Compare
.github/workflows/benchmark.yaml
Outdated
|
||
- name: Combine all results | ||
run: cat results/*.json > ${{github.sha}}_benchmark_result.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be enough to order results? wondering what will be the way to put this in a graph later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a timestamp in the data too which we can use for ordering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should the
benchmark
workflow have aworkflow_dispatch
event so that it can be run manually as well as on merge? - The
benchmark-results.json
file in S3 is currently empty even though this workflow looks like it's been run a few times. Is that expected?
Will do
Yep, that's fine. I've been throwing away the test runs on the PR since they'll have an incorrect SHA. |
Benchmark results are now collected to a json file which will be appended to a file in s3.
Another action will generate static HTML from these results and push them to GitHub Pages.