Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist benchmark results in CI #461

Merged
merged 39 commits into from
Nov 18, 2024
Merged

Persist benchmark results in CI #461

merged 39 commits into from
Nov 18, 2024

Conversation

ryanslade
Copy link
Contributor

@ryanslade ryanslade commented Nov 12, 2024

Benchmark results are now collected to a json file which will be appended to a file in s3.

Another action will generate static HTML from these results and push them to GitHub Pages.

@ryanslade ryanslade changed the title Rs/save benchmark report Persist benchmark results in CI Nov 12, 2024
@ryanslade ryanslade force-pushed the rs/save-benchmark-report branch from dfca335 to 27a1b3a Compare November 12, 2024 11:17

- name: Combine all results
run: cat results/*.json > ${{github.sha}}_benchmark_result.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this be enough to order results? wondering what will be the way to put this in a graph later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a timestamp in the data too which we can use for ordering.

@ryanslade ryanslade marked this pull request as ready for review November 15, 2024 10:23
@ryanslade ryanslade requested a review from a team November 15, 2024 10:23
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should the benchmark workflow have a workflow_dispatch event so that it can be run manually as well as on merge?
  • The benchmark-results.json file in S3 is currently empty even though this workflow looks like it's been run a few times. Is that expected?

@ryanslade
Copy link
Contributor Author

  • Should the benchmark workflow have a workflow_dispatch event so that it can be run manually as well as on merge?

Will do

  • The benchmark-results.json file in S3 is currently empty even though this workflow looks like it's been run a few times. Is that expected?

Yep, that's fine. I've been throwing away the test runs on the PR since they'll have an incorrect SHA.

@ryanslade ryanslade merged commit e044c56 into main Nov 18, 2024
27 checks passed
@ryanslade ryanslade deleted the rs/save-benchmark-report branch November 18, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants