Skip to content

Commit

Permalink
Do not use copytruncate for xcat log rotation
Browse files Browse the repository at this point in the history
PR #6510 tried to fix missing logs for goconserver, but also added copytruncate to all xcat logs in /var/log/xcat*.log. This is not needed because these logs are written by rsyslog and xcat itself, not goconserver.

The main rsyslog developer does not recommend to use copytruncate for rsyslog: https://serverfault.com/a/901366

For HA setups with logs on NFS etc. copytruncate can be very slow.
  • Loading branch information
Obihoernchen authored Feb 23, 2024
1 parent 540fbf2 commit fc80e75
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion xCAT/etc/logrotate.d/xcat
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/var/log/xcat/*.log {
missingok
sharedscripts
copytruncate
delaycompress
postrotate
test -f /var/run/rsyslogd.pid && kill -HUP `cat /var/run/rsyslogd.pid 2> /dev/null` 2> /dev/null || true
Expand Down

0 comments on commit fc80e75

Please sign in to comment.