fixup! zfs-vol: implement Volume.snapshot 2/n

xcp-ng · Apr 3, 2024 · 59c85fa · 59c85fa
1 parent be45c5a
commit 59c85fa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/plugins/volume/org.xen.xapi.storage.zfs-vol/sr.py b/plugins/volume/org.xen.xapi.storage.zfs-vol/sr.py
@@ -135,8 +135,8 @@ def ls(self, dbg, sr):
                 if is_snapshot:
                     vol_name = zfsutils.zvol_find_snap_path(dbg, pool_name, vdi.volume.id)
                     if vol_name is None:
-                        # FIXME is there a way to return an error entry instead?
-                        raise Exception("snapshot volume %s not found on disk" % (vdi.volume.id))
+                        log.error("snapshot volume %s not found on disk", vdi.volume.id)
+                        continue
                 else:
                     vol_name = zfsutils.zvol_path(pool_name, vdi.volume.id)
                 psize = zfsutils.vol_get_used(dbg, vol_name)