Fix several issues in import_srpm #683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yann Dirson <[email protected]>
I was regularly losing time debugging this script exploding when just forgetting to use `-c`. Switching back to `master` after making changes and NOT committing them has just NO WAY to ever work. Signed-off-by: Yann Dirson <[email protected]>
glehmann
approved these changes
Mar 7, 2025
| import os | ||
| import subprocess | ||
|
|
||
| def call_process(args): |
There was a problem hiding this comment.
call is probably clear enough in that context, and pleasantly shorter
There was a problem hiding this comment.
Hm, I'm a bit wary of using generic names, especially when it's so cheap to be more specific
stormi
approved these changes
Mar 12, 2025
When we used `create_rpm_git_repo.py --local`, there may be no remote to pull from yet. Should indeed have been part of c2d89af. Signed-off-by: Yann Dirson <[email protected]>
|
Added another small fix still in the "fix import" scope, adjusting PR name to encompass it |
ydirson
changed the title
-c
glehmann
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.