Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to uv builds #126

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Migrate to uv builds #126

merged 8 commits into from
Dec 6, 2024

Conversation

cboulay
Copy link
Contributor

@cboulay cboulay commented Dec 5, 2024 •
edited
Loading

Note: Using "trusted publisher" between pypi <--> GitHub, the uv build and uv publish steps are quite simple and don't require tokens or an intermediate artifact.

__version__.py file written upon build based on the tag. If the most recent commit is beyond the latest tag then the version will be appended with a commit hash.

@cboulay cboulay requested a review from cbrnr December 5, 2024 15:21
cbrnr
cbrnr reviewed Dec 6, 2024
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
cbrnr
cbrnr reviewed Dec 6, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
cbrnr
cbrnr reviewed Dec 6, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
cbrnr
cbrnr reviewed Dec 6, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
cbrnr
cbrnr reviewed Dec 6, 2024
View reviewed changes
test/__init__.py Outdated Show resolved Hide resolved
cbrnr
cbrnr reviewed Dec 6, 2024
View reviewed changes
src/pyxdf/__init__.py Outdated Show resolved Hide resolved
@cbrnr cbrnr mentioned this pull request Dec 6, 2024
Open
@cbrnr
Copy link
Contributor

cbrnr commented Dec 6, 2024

After this PR is merged, I'd like to cut a new release (which is a nice test if the new uv publish works). I think we should bump to 1.17.0 this time.

@cboulay cboulay changed the base branch from dev to main December 6, 2024 13:21
@cboulay cboulay linked an issue Dec 6, 2024 that may be closed by this pull request
Use uv for project management #125
Closed
@cboulay
Copy link
Contributor Author

cboulay commented Dec 6, 2024

I'm in transit today. If there are any finishing touches you want to do then please go ahead without me.

@cbrnr
Copy link
Contributor

cbrnr commented Dec 6, 2024

This looks good to me except for one point: I'm not entirely convinced that we should include uv.lock under version control. I know that the general recommendation is to include it, but I view pyxdf as a library (as opposed to an application), in which case I'd rather not limit a user's environment, since they will use pyxdf in combination with many other packages that we cannot (and don't want to) control.

@cboulay
Copy link
Contributor Author

cboulay commented Dec 6, 2024

OK ready to go. You're welcome to squash if you want when merging.

@cbrnr cbrnr merged commit b718033 into main Dec 6, 2024
5 checks passed
@cbrnr cbrnr deleted the 125-use-uv-for-project-management branch December 6, 2024 19:37
@cbrnr
Copy link
Contributor

cbrnr commented Dec 6, 2024

Thanks @cboulay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrnr cbrnr cbrnr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use uv for project management
2 participants
@cboulay @cbrnr