dialects: (measurement) add dialect and attributes for measurement #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimxworrall
reviewed
Jan 31, 2025
alexarice
changed the title
|
Don't think I renamed the test files... |
|
Nevermind I didn't have any on this PR |
|
MeasureXYAttr is tested as part of qssa. Has its own test added in the next PR |
alexarice
force-pushed
the
alexarice/measure-attrs
branch
from
3269d32 to
95f9c8b
Compare
alexarice
force-pushed
the
alexarice/measure-attrs
branch
from
95f9c8b to
2ca7470
Compare
|
I'm going to start merging, we can iterate on names later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds attributes for measurement similar to the attributes for allocation and gates.