Skip to content

Commit

Permalink
misc: use .venv by default instead of venv (#3629)
Browse files Browse the repository at this point in the history
I didn't want to have this discussion before we merged uv, but it
definitely feels like it really prefers `.venv`, and makes lots of
things easier if this name is used. How do we feel about using this name
by default? It can still easily be overridden locally, but will change
to .venv by default for everyone.
  • Loading branch information
superlopuh authored Dec 12, 2024
1 parent 3e999aa commit dd61f4d
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 7 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ jobs:
build:

runs-on: ubuntu-latest
env:
VENV_DIR: .venv
strategy:
matrix:
python-version: ['3.10', '3.11', '3.12', '3.13']
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci-mlir.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
python-version: ['3.10', '3.11', '3.12']

env:
VENV_DIR: .venv
LLVM_SYMBOLIZER_PATH: /usr/lib/llvm-11/bin/llvm-symbolizer
MLIR-Version: d401987fe349a87c53fe25829215b080b70c0c1a
steps:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ci-notebooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ jobs:
build:

runs-on: ubuntu-latest
env:
VENV_DIR: .venv
strategy:
matrix:
python-version: ['3.10', '3.11', '3.12']
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci-pyright-fails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
python-version: ["3.10", "3.11", "3.12"]

env:
VENV_DIR: .venv
PYRIGHT_VERSION: 1.0

steps:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ MAKEFLAGS += --no-builtin-variables
COVERAGE_FILE ?= .coverage

# allow overriding the name of the venv directory
VENV_DIR ?= venv
VENV_DIR ?= .venv
UV_PROJECT_ENVIRONMENT=${VENV_DIR}

# allow overriding which extras are installed
Expand Down

0 comments on commit dd61f4d

Please sign in to comment.