Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: stencil bufferization polish #3001

Merged
merged 18 commits into from
Aug 17, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Aug 9, 2024

Step back on the idea of allocating all apply results to then fold away and instead just fold stores into apply. It's cheaper, simpler, and so far works just as well!

Also rely on the new side-effect value information to improve side-effect analysis.

Both changes allow to bufferize a full open earth compiler example now!

Minor test changes, the bufferization used to blindly allocate buffers for unused results, now it scraps them. I guess it's debatable if that should be its role? Note that it does so by reusing the canonicalization pattern, no logic is actually duplicated.

@PapyChacal PapyChacal added the transformations Changes or adds a transformatio label Aug 9, 2024
@PapyChacal PapyChacal self-assigned this Aug 9, 2024
This significantly lift analysis difficulty on the whole apply/load/store; might be slightly less generic?
For now, it's a step forward.
@PapyChacal PapyChacal force-pushed the emilien/better-bufferization branch from 45e7d94 to 65ae4b6 Compare August 9, 2024 12:39
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (7473b87) to head (a914a27).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3001      +/-   ##
==========================================
+ Coverage   89.86%   89.88%   +0.02%     
==========================================
  Files         415      415              
  Lines       52078    52095      +17     
  Branches     8048     8047       -1     
==========================================
+ Hits        46799    46826      +27     
+ Misses       3984     3977       -7     
+ Partials     1295     1292       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal changed the title transformations: stencil bufferization polish [WIP] transformations: stencil bufferization polish Aug 9, 2024
@PapyChacal PapyChacal marked this pull request as ready for review August 15, 2024 11:03
@PapyChacal PapyChacal changed the title [WIP] transformations: stencil bufferization polish transformations: stencil bufferization polish Aug 16, 2024
@PapyChacal PapyChacal requested a review from superlopuh August 16, 2024 13:09
@PapyChacal PapyChacal merged commit b01afed into main Aug 17, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/better-bufferization branch August 17, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants