-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transformations: stencil bufferization polish #3001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es on stencil ops.
This significantly lift analysis difficulty on the whole apply/load/store; might be slightly less generic? For now, it's a step forward.
PapyChacal
force-pushed
the
emilien/better-bufferization
branch
from
August 9, 2024 12:39
45e7d94
to
65ae4b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3001 +/- ##
==========================================
+ Coverage 89.86% 89.88% +0.02%
==========================================
Files 415 415
Lines 52078 52095 +17
Branches 8048 8047 -1
==========================================
+ Hits 46799 46826 +27
+ Misses 3984 3977 -7
+ Partials 1295 1292 -3 ☔ View full report in Codecov by Sentry. |
PapyChacal
changed the title
transformations: stencil bufferization polish
[WIP] transformations: stencil bufferization polish
Aug 9, 2024
superlopuh
reviewed
Aug 15, 2024
superlopuh
reviewed
Aug 15, 2024
PapyChacal
changed the title
[WIP] transformations: stencil bufferization polish
transformations: stencil bufferization polish
Aug 16, 2024
Co-authored-by: Sasha Lopoukhine <[email protected]>
n-io
approved these changes
Aug 16, 2024
superlopuh
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step back on the idea of allocating all apply results to then fold away and instead just fold stores into apply. It's cheaper, simpler, and so far works just as well!
Also rely on the new side-effect value information to improve side-effect analysis.
Both changes allow to bufferize a full open earth compiler example now!
Minor test changes, the bufferization used to blindly allocate buffers for unused results, now it scraps them. I guess it's debatable if that should be its role? Note that it does so by reusing the canonicalization pattern, no logic is actually duplicated.