-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transformations: Decouple distribute-stencil
from shape-inference
#3054
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 415 416 +1
Lines 52426 52436 +10
Branches 8111 8114 +3
=======================================
+ Hits 47121 47131 +10
Misses 4000 4000
Partials 1305 1305 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Please can you leave a comment whether dmp needs to run before/after shape inference, or does either work equally well?
Shape inference would need to run after dmp. DMP is just structurally placing "when" communications might need to happen. Shape inference allows to infer what needs to be communicated at those points. This drop-in replacement order is indicated by the update of |
Make dmp shape inference part of the general
shape-inference
, and removeshape-inference
as a part ofdistribute-stencil
.Stacked on: