Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: Decouple distribute-stencil from shape-inference #3054

Merged
merged 21 commits into from
Aug 19, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Aug 17, 2024

Make dmp shape inference part of the general shape-inference, and remove shape-inference as a part of distribute-stencil.

Stacked on:

@PapyChacal PapyChacal added dialects Changes on the dialects transformations Changes or adds a transformatio labels Aug 17, 2024
@PapyChacal PapyChacal requested review from AntonLydike and n-io August 17, 2024 12:55
@PapyChacal PapyChacal self-assigned this Aug 17, 2024
@PapyChacal PapyChacal changed the base branch from main to emilien/dmp-strategy August 17, 2024 12:55
@PapyChacal PapyChacal marked this pull request as ready for review August 17, 2024 13:00
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (f9df366) to head (ff58a95).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3054   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files         415      416    +1     
  Lines       52426    52436   +10     
  Branches     8111     8114    +3     
=======================================
+ Hits        47121    47131   +10     
  Misses       4000     4000           
  Partials     1305     1305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@n-io n-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Please can you leave a comment whether dmp needs to run before/after shape inference, or does either work equally well?

@PapyChacal
Copy link
Collaborator Author

Looks good, thanks! Please can you leave a comment whether dmp needs to run before/after shape inference, or does either work equally well?

Shape inference would need to run after dmp. DMP is just structurally placing "when" communications might need to happen. Shape inference allows to infer what needs to be communicated at those points.
Ideally, shape inference could happen before too, and just happen again on the swaps if needed. This is not tested at this point though, and I would expect it to fail from experience.

This drop-in replacement order is indicated by the update of distribute-stencil.mlir

Base automatically changed from emilien/dmp-strategy to main August 19, 2024 12:19
@PapyChacal PapyChacal merged commit 5c4bcf4 into main Aug 19, 2024
9 checks passed
@PapyChacal PapyChacal deleted the emilien/dmp-inference branch August 19, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants