-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: Update dmp.swap #3056
Conversation
…tic. Also for now make it work on stencil types directly, to think about at some point. I think we could use interfaces for that (value vs reference).
@n-io I'm completely lost with regards to what's breaking where in your |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3056 +/- ##
==========================================
- Coverage 89.88% 89.86% -0.02%
==========================================
Files 416 416
Lines 52436 52466 +30
Branches 8114 8123 +9
==========================================
+ Hits 47131 47151 +20
- Misses 4000 4005 +5
- Partials 1305 1310 +5 ☔ View full report in Codecov by Sentry. |
Thanks @n-io ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you add filechecks for both value and reference semantics if not already present?
Already done in |
Yes, but it would benefit from also being in the transformation (this PR has a transformation label). |
For the PR's record, also done in |
Give it a proper signature for value-semantics and reference-semantics.
It now needs to return values if taking values in, and need only an in-place operand if reference-semantics.
Update the distribution pass, to replace the loaded values by the swapped values, building a consistent def-use chain.