Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: Update dmp.swap #3056

Merged
merged 31 commits into from
Aug 19, 2024
Merged

dialects: Update dmp.swap #3056

merged 31 commits into from
Aug 19, 2024

Conversation

PapyChacal
Copy link
Collaborator

Give it a proper signature for value-semantics and reference-semantics.
It now needs to return values if taking values in, and need only an in-place operand if reference-semantics.

Update the distribution pass, to replace the loaded values by the swapped values, building a consistent def-use chain.

@PapyChacal PapyChacal added dialects Changes on the dialects transformations Changes or adds a transformatio labels Aug 17, 2024
@PapyChacal PapyChacal self-assigned this Aug 17, 2024
@PapyChacal
Copy link
Collaborator Author

@n-io I'm completely lost with regards to what's breaking where in your stencil-to-csl-stencil pass. Could you please have a look?

@PapyChacal PapyChacal requested a review from n-io August 18, 2024 11:10
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (5c4bcf4) to head (94b22f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3056      +/-   ##
==========================================
- Coverage   89.88%   89.86%   -0.02%     
==========================================
  Files         416      416              
  Lines       52436    52466      +30     
  Branches     8114     8123       +9     
==========================================
+ Hits        47131    47151      +20     
- Misses       4000     4005       +5     
- Partials     1305     1310       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal marked this pull request as ready for review August 19, 2024 10:25
@PapyChacal
Copy link
Collaborator Author

Thanks @n-io !

Copy link
Collaborator

@n-io n-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add filechecks for both value and reference semantics if not already present?

@PapyChacal
Copy link
Collaborator Author

Please could you add filechecks for both value and reference semantics if not already present?

Already done in tests/filecheck/dialects/dmp/canonicalize.mlir and tests/filecheck/dialects/dmp/ops.mlir ?

Base automatically changed from emilien/dmp-inference to main August 19, 2024 12:27
@n-io
Copy link
Collaborator

n-io commented Aug 19, 2024

Please could you add filechecks for both value and reference semantics if not already present?

Already done in tests/filecheck/dialects/dmp/canonicalize.mlir and tests/filecheck/dialects/dmp/ops.mlir ?

Yes, but it would benefit from also being in the transformation (this PR has a transformation label).

@PapyChacal
Copy link
Collaborator Author

Please could you add filechecks for both value and reference semantics if not already present?

Already done in tests/filecheck/dialects/dmp/canonicalize.mlir and tests/filecheck/dialects/dmp/ops.mlir ?

Yes, but it would benefit from also being in the transformation (this PR has a transformation label).

Please could you add filechecks for both value and reference semantics if not already present?

Already done in tests/filecheck/dialects/dmp/canonicalize.mlir and tests/filecheck/dialects/dmp/ops.mlir ?

Yes, but it would benefit from also being in the transformation (this PR has a transformation label).

For the PR's record, also done in tests/filecheck/transforms/distribute-stencil.mlir and tests/filecheck/transforms/stencil-to-csl-stencil.mlir

@PapyChacal PapyChacal merged commit 4704025 into main Aug 19, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/dmp-ping branch August 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants