transformations: (cf) switch canonicalization #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
dialects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3291 +/- ##
=======================================
Coverage 90.01% 90.02%
=======================================
Files 445 445
Lines 55956 56049 +93
Branches 5364 5378 +14
=======================================
+ Hits 50370 50458 +88
- Misses 4177 4180 +3
- Partials 1409 1411 +2 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Oct 14, 2024
There was a problem hiding this comment.
nit: it's slightly confusing to have the block indices be different in the inputs and outputs
superlopuh
reviewed
Oct 14, 2024
superlopuh
reviewed
Oct 14, 2024
superlopuh
reviewed
Oct 14, 2024
superlopuh
reviewed
Oct 14, 2024
| -> br ^bb2 | ||
| """ | ||
| case_values = switch.case_values | ||
| if case_values is not None: |
There was a problem hiding this comment.
does it make sense for this to be optional? Shouldn't it be () by default?
There was a problem hiding this comment.
It is an optional property in mlir. I don't personally think it makes any sense but it is what it is
superlopuh
reviewed
Oct 14, 2024
superlopuh
approved these changes
Oct 14, 2024
alexarice
force-pushed
the
alexarice/switch-canon
branch
from
07fd41f to
fc0e077
Compare
alexarice
force-pushed
the
alexarice/switch-canon
branch
from
2ea46d1 to
51436cf
Compare
|
@superlopuh happy for this to be merged? |
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
Adds all the switch canonicalization patterns present in mlir. --------- Co-authored-by: Sasha Lopoukhine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all the switch canonicalization patterns present in mlir. I'm happy to anonymise some of the block names in the filecheck tests if this is deemed worth doing.