Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (linalg-to-csl) Lower generic to fmac(h|s) #3345

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Oct 25, 2024

Checks if a linalg.generic op is a fused multiply-add and lowers it to fmacs or fmach, depending on the precision.

@n-io n-io added the transformations Changes or adds a transformatio label Oct 25, 2024
@n-io n-io self-assigned this Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (3c60932) to head (876dfba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3345      +/-   ##
==========================================
- Coverage   90.09%   90.08%   -0.01%     
==========================================
  Files         447      447              
  Lines       56494    56512      +18     
  Branches     5431     5434       +3     
==========================================
+ Hits        50896    50907      +11     
- Misses       4163     4167       +4     
- Partials     1435     1438       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the order of operands in the actual fmacs call

xdsl/transforms/linalg_to_csl.py Show resolved Hide resolved
xdsl/transforms/linalg_to_csl.py Outdated Show resolved Hide resolved
@n-io n-io requested a review from dk949 October 28, 2024 17:33
@n-io n-io merged commit f9123d0 into main Oct 29, 2024
13 checks passed
@n-io n-io deleted the nicolai/linalg-generic-fma-to-csl branch October 29, 2024 13:57
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
…ect#3345)

Checks if a `linalg.generic` op is a fused multiply-add and lowers it to
`fmacs` or `fmach`, depending on the precision.

---------

Co-authored-by: n-io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants