Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialects: (llvm) Added pretty printing to llvm.mlir.constant #3352

Merged
merged 5 commits into from
Oct 30, 2024
Merged

dialects: (llvm) Added pretty printing to llvm.mlir.constant #3352

merged 5 commits into from
Oct 30, 2024

Conversation

lfrenot
Copy link
Collaborator

@lfrenot lfrenot commented Oct 29, 2024

No description provided.

@lfrenot lfrenot added the dialects Changes on the dialects label Oct 29, 2024
@lfrenot lfrenot requested a review from tobiasgrosser October 29, 2024 14:46
@lfrenot lfrenot self-assigned this Oct 29, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (f9123d0) to head (3a454ba).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3352      +/-   ##
==========================================
+ Coverage   90.05%   90.09%   +0.04%     
==========================================
  Files         447      447              
  Lines       56552    56577      +25     
  Branches     5428     5431       +3     
==========================================
+ Hits        50928    50974      +46     
+ Misses       4188     4166      -22     
- Partials     1436     1437       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lfrenot lfrenot requested a review from luisacicolini October 29, 2024 15:43
superlopuh
superlopuh reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please install the pre-commit hook with make precommit-install, and run make precommit to format? Then I'd recommend running make tests to make sure the tests pass.

luisacicolini
luisacicolini approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@luisacicolini luisacicolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tobiasgrosser
Copy link
Contributor

Nice. Ready to merge?

@lfrenot
Copy link
Collaborator Author

lfrenot commented Oct 29, 2024

I think so
@superlopuh do you have any comment?

@tobiasgrosser
Copy link
Contributor

Let's merge this for now. @superlopuh, let us know if we missed sth.

@tobiasgrosser tobiasgrosser merged commit a282e6d into main Oct 30, 2024
14 checks passed
@tobiasgrosser tobiasgrosser deleted the pretty-llvm-constant branch October 30, 2024 00:27
@superlopuh
Copy link
Member

LGTM!

EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
@lfrenot @EdmundGoodman
dialects: (llvm) Added pretty printing to llvm.mlir.constant (xdslpro…
d1c3db5 
…ject#3352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superlopuh superlopuh superlopuh left review comments

@luisacicolini luisacicolini luisacicolini approved these changes

@tobiasgrosser tobiasgrosser tobiasgrosser approved these changes

Assignees

@lfrenot lfrenot

Labels
dialects Changes on the dialects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfrenot @tobiasgrosser @superlopuh @luisacicolini