Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive: fix dark mode #3582

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

alexarice
Copy link
Collaborator

Fixes crash when switching theme caused by a textual update. Also adds a test to catch this in the future.

@alexarice alexarice added bug Something isn't working minor For minor PRs, easy and quick to review, quickly mergeable interactive xdsl-gui things labels Dec 6, 2024
@alexarice alexarice self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (f33fbde) to head (7d7e475).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3582   +/-   ##
=======================================
  Coverage   90.39%   90.40%           
=======================================
  Files         467      469    +2     
  Lines       58870    58950   +80     
  Branches     5609     5611    +2     
=======================================
+ Hits        53218    53295   +77     
- Misses       4207     4213    +6     
+ Partials     1445     1442    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexarice alexarice merged commit b5acf31 into main Dec 6, 2024
15 checks passed
@alexarice alexarice deleted the alexarice/interactive/dark-mode branch December 6, 2024 13:03
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
Fixes crash when switching theme caused by a textual update. Also adds a
test to catch this in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working interactive xdsl-gui things minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants