Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: (Toy) use generic parser in Toy #3596

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

superlopuh
Copy link
Member

Exercises the genericness of proposed generic parser infrastructure.

Note stacked PR.

@superlopuh superlopuh added the documentation Improvements or additions to documentation label Dec 8, 2024
@superlopuh superlopuh requested a review from math-fehr December 8, 2024 14:24
@superlopuh superlopuh self-assigned this Dec 8, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (8459f95) to head (a6f8b14).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3596   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files         470      471    +1     
  Lines       59127    59112   -15     
  Branches     5610     5607    -3     
=======================================
- Hits        53452    53442   -10     
+ Misses       4232     4230    -2     
+ Partials     1443     1440    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see number of lines going down, I'm happy

@superlopuh superlopuh force-pushed the sasha/parser/generic-parser branch from 189b337 to b34ff53 Compare December 9, 2024 18:29
@superlopuh superlopuh force-pushed the sasha/parser/toy-generic-parser branch from a20d066 to a6f8b14 Compare December 9, 2024 18:29
Base automatically changed from sasha/parser/generic-parser to main December 9, 2024 19:24
@superlopuh superlopuh merged commit f7d39a1 into main Dec 9, 2024
15 checks passed
@superlopuh superlopuh deleted the sasha/parser/toy-generic-parser branch December 9, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants