Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: initialize mlir-aie CI #3644

Closed
wants to merge 2 commits into from
Closed

CI: initialize mlir-aie CI #3644

wants to merge 2 commits into from

Conversation

jorendumoulin
Copy link
Collaborator

This PR initalizes the CI workflow for mlir-aie based testing.

There are no tests yet, so nothing is tested except for printing out the mlir-aie version to see if we can use it correctly.

The project does not really have a versioning strategy, but rather regularly updates its llvm commit, and pushes prebuilt binaries daily with the release version 0.0.1.<date>+<commit>.

As the mlir version of mlir-aie will not necessarily correspond to the mlir verison of xdsl, i suggest only testing mlir-aie specific dialects with this ci (which I imagine will reside in /tests/filecheck/with-mlir-aie/dialects/aie.mlir)

@jorendumoulin jorendumoulin self-assigned this Dec 16, 2024
@jorendumoulin jorendumoulin added the CI Continuous Integration label Dec 16, 2024
@jorendumoulin jorendumoulin marked this pull request as ready for review December 16, 2024 15:29
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (fd6296d) to head (165715a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3644   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         467      467           
  Lines       58905    58905           
  Branches     5639     5639           
=======================================
  Hits        53460    53460           
  Misses       4001     4001           
  Partials     1444     1444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member

Maybe it's time to discuss moving the aie things to a new project in xdslproject called xdsl-aie or something like that

@jorendumoulin
Copy link
Collaborator Author

I am happy to! I am now just basing myself on my poll here https://xdsl.zulipchat.com/#narrow/channel/364199-Beginners/topic/AMD.20AIE.3F

@superlopuh
Copy link
Member

In a way, the extra CI changes the inputs to the poll somewhat. It might be worth picking it up there, but I think that it makes sense to have subprojects like this one in a separate project. I'm still happy to volunteer to update the APIs when we change them.

@compor
Copy link
Collaborator

compor commented Dec 17, 2024

We have done both recently (in and downstream of the repo), so not sure what the actual criteria are.
I'd be happy to support this wherever it lives.

Maybe we can continue as we are with the requirement that AIE stuff moves to main and have a separate CI repo for that?
Not the greatest setup, I have to admit, but if the CI support is the sticky issue we can circumvent for now?

@jorendumoulin
Copy link
Collaborator Author

development moved to xdslproject/xdsl-aie#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants