-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interactive: mlir-gui version 1 #3667
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3667 +/- ##
==========================================
- Coverage 91.30% 90.88% -0.42%
==========================================
Files 466 468 +2
Lines 58357 58626 +269
Branches 5624 5651 +27
==========================================
Hits 53280 53280
- Misses 3628 3897 +269
Partials 1449 1449 ☔ View full report in Codecov by Sentry. |
Hi @dshaaban01, any updates on this? If we want to merge it to the xDSL repo, I think it would be great to find a way to integrate it into xdsl-gui, hopefully via logic encapsulated on the MLIROptPass itself. |
Hi. I agree. I will work on this in my spare time - I am overloaded with other things until mid April, but will try to work on this sporadically until then, and then focus on it end of April/beginning of May. Will close this PR for now and will reopen smaller PR's to begin integration when the time comes. |
This is a first attempt at creating an mlir-gui. I would like to upstream it (still figuring out whether to do that in this repo or in the mlir repo). Open to feedback/advice from anyone interested :)
It is very similar to xdsl-gui, with some changes:
mlir-opt --passes
, no xdsl-passesmlir-gui
in terminal to get it :)Some open questions:
Note: It is not perfect and has some errors if you search hard enough (especially with pass selection)! Still needs work, this is just version 1 :)