Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: raise ddot bottom_up test to linalg.generic #3678

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

superlopuh
Copy link
Member

Last one of the f64, we didn't include it in the paper in the end, but it's worth keeping track of.

Note stacked PR

@superlopuh superlopuh added the testing PRs that modify tests label Dec 25, 2024
@superlopuh superlopuh self-assigned this Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (298bbba) to head (7ec51f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3678   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         466      466           
  Lines       58357    58357           
  Branches     5624     5624           
=======================================
+ Hits        53281    53283    +2     
+ Misses       3628     3627    -1     
+ Partials     1448     1447    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mamanain mamanain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

%X : memref<128xf64>,
%Y : memref<128xf64>,
%G : memref<f64>
%X: memref<128xf64> {llvm.noalias},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this attribute here but not other tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it's always needed it, and we make some incorrect assumptions of non-aliasing in our lowering. In the riscv-paper-experiments repo, we have them on all the kernels, as LLVM doesn't do the same optimisations without these annotations.

Base automatically changed from sasha/snitch-tensor/streamify-empty to main December 26, 2024 11:45
@superlopuh superlopuh merged commit 346e1d4 into main Dec 31, 2024
16 checks passed
@superlopuh superlopuh deleted the sasha/snitch-tensor/linalg branch December 31, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants