documentation: (marimo) use jupyter notebooks for easier reviewing #3722
+1,203
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
AntonLydike,
alexarice,
mamanain,
math-fehr,
qaco,
n-io,
jorendumoulin,
webmiche and
dshaaban01
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Sad times, marimo exports the cells in notebook order, not in topological sort order, closing for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3722 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 468 468
Lines 58605 58605
Branches 5656 5656
=======================================
Hits 53496 53496
Misses 3659 3659
Partials 1450 1450 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Jan 8, 2025
|
ReviewNB doesn't work for marimo, though, as far as I'm aware |
superlopuh
force-pushed
the
sasha/marimo/jupyter-notebooks
branch
from
35e567f to
f73b9ce
Compare
yeah, just played around with it more and there is no support, just viewing the cells; sad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub already has custom UIs for Jupyter notebooks, this will let us more easily review the marimo notebook changes using that UI.