interactive: AvailablePass now has either a pass type or instance, no spec #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
alexarice,
n-io,
jorendumoulin and
dshaaban01
superlopuh
commented
Jan 8, 2025
Comment on lines
+353
to
+355
| data=(type(value), value.pipeline_pass_spec()) | ||
| if isinstance(value, ModulePass) | ||
| else (value, None), |
There was a problem hiding this comment.
This is a newly introduced ugly bit due to the tree node data still being in terms of pass type and spec, next PR will remove this.
n-io
approved these changes
Jan 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3725 +/- ##
==========================================
- Coverage 91.28% 91.28% -0.01%
==========================================
Files 468 468
Lines 58605 58601 -4
Branches 5656 5656
==========================================
- Hits 53496 53492 -4
Misses 3659 3659
Partials 1450 1450 ☔ View full report in Codecov by Sentry. |
n-io
reviewed
Jan 8, 2025
| @@ -82,25 +81,15 @@ def test_get_all_available_passes(): | |||
| ( | |||
| AvailablePass( | |||
| display_name="bc", | |||
| module_pass=BCPass, | |||
| pass_spec=None, | |||
| module_pass=BCPass(), | |||
There was a problem hiding this comment.
nit: It looks like AvailablePass can still be built with a type?
There was a problem hiding this comment.
Yep, this is used when "Condense Mode" is not on, and for mlir-opt pass as we want to present the pass as an option to the user without instantiating it
compor
approved these changes
Jan 8, 2025
dshaaban01
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same deal as #3723, we used to need the spec due to potential mutability, now don't need it.