-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (arith) Add support for bitcast operation #3805
Conversation
catch up to main
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3805 +/- ##
==========================================
+ Coverage 91.23% 91.27% +0.03%
==========================================
Files 461 462 +1
Lines 57487 57719 +232
Branches 5548 5569 +21
==========================================
+ Hits 52449 52683 +234
+ Misses 3615 3614 -1
+ Partials 1423 1422 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good, thanks for this. I've left a few comments.
I've made all the changes suggested besides moving that function to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits!
@jakedves, as a convention, we tend to let the original commenter resolve the messages, it makes it easier to see how the change was addressed, and whether the conversation is really resolved. |
tests/filecheck/mlir-conversion/with-mlir/dialects/arith/arith_bcast.mlir
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo a green CI run (the mlir-opt
flag has a typo)
tests/filecheck/mlir-conversion/with-mlir/dialects/arith/arith_bcast.mlir
Outdated
Show resolved
Hide resolved
Thank you for this! |
Implementation of MLIR's
arith.bitcast
op. Test cases are passing but type checking ont1
andt2
variables isn't