Merge pull request #164 from jmxendit/feat/Add-Support-For-Klikpay

Feat/add support for klikpay
xendit · Jul 15, 2022 · 8242f6e · 8242f6e
2 parents 172ddcb + 29705c0
commit 8242f6e
Show file tree

Hide file tree

Showing 8 changed files with 36 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -1349,6 +1349,7 @@ dd.getPaymentMethodsByCustomerID(data: {
 ```ts
 dd.createDirectDebitPayment(data: {
   idempotencyKey: string;
+  apiVersion?: string;
   referenceID: string;
   paymentMethodID: string;
   currency: string;
@@ -1359,6 +1360,8 @@ dd.createDirectDebitPayment(data: {
   basket?: Basket[];
   device?: object;
   metadata?: object;
+  successRedirectUrl?: string;
+  failureRedirectUrl?: string;
 });
 ```
 
@@ -1368,6 +1371,7 @@ dd.createDirectDebitPayment(data: {
 dd.validateOTPforPayment(data: {
   directDebitID: string;
   otpCode: string;
+  apiVersion?: string;
 })
 ```
 

diff --git a/integration_test/card.test.js b/integration_test/card.test.js
@@ -17,7 +17,7 @@ module.exports = function() {
         minOriginalAmount: 25000,
         maxDiscountAmount: 5000,
         startTime: '2022-03-25T00:00:00.000Z',
-        endTime: '2022-05-25T00:00:00.000Z',
+        endTime: '2025-05-25T00:00:00.000Z',
       }),
     )
     .then(() => {

diff --git a/integration_test/direct_debit.test.js b/integration_test/direct_debit.test.js
@@ -58,6 +58,7 @@ module.exports = function() {
     .then(r =>
       dd.createDirectDebitPayment({
         idempotencyKey: new Date().toISOString(),
+        apiVersion: null,
         referenceID: 'merchant-ref-id-ex-1',
         paymentMethodID: r[0].id,
         currency: 'IDR',
@@ -96,6 +97,7 @@ module.exports = function() {
       dd.validateOTPforPayment({
         directDebitID: r.id,
         otpCode: '222000',
+        apiVersion: null,
       }),
     )
     .then(r =>

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "xendit-node",
-  "version": "1.21.4",
+  "version": "1.21.5",
   "description": "NodeJS client for Xendit API",
   "main": "index.js",
   "types": "index.d.ts",

diff --git a/src/direct_debit/direct_debit_payment.d.ts b/src/direct_debit/direct_debit_payment.d.ts
@@ -14,6 +14,7 @@ interface Basket {
 
 export function createDirectDebitPayment(data: {
   idempotencyKey: string;
+  apiVersion?: string;
   referenceID: string;
   paymentMethodID: string;
   currency: string;
@@ -24,11 +25,14 @@ export function createDirectDebitPayment(data: {
   basket?: Basket[];
   device?: object;
   metadata?: object;
+  successRedirectUrl?: string;
+  failureRedirectUrl?: string;
 }): Promise<object>;
 
 export function validateOTPforPayment(data: {
   directDebitID: string;
   otpCode: string;
+  apiVersion?: string;
 }): Promise<object>;
 
 export function getDirectDebitPaymentStatusByID(data: {

diff --git a/src/direct_debit/direct_debit_payment.js b/src/direct_debit/direct_debit_payment.js
@@ -12,13 +12,18 @@ function createDirectDebitPayment(data) {
     ];
     Validate.rejectOnMissingFields(compulsoryFields, data, reject);
 
+    const headers = {
+      Authorization: Auth.basicAuthHeader(this.opts.secretKey),
+      'Content-Type': 'application/json',
+      'Idempotency-key': data.idempotencyKey,
+    };
+    if (data.apiVersion !== null) {
+      headers['Api-Version'] = data.apiVersion;
+    }
+
     fetchWithHTTPErr(`${this.API_ENDPOINT}/direct_debits`, {
       method: 'POST',
-      headers: {
-        Authorization: Auth.basicAuthHeader(this.opts.secretKey),
-        'Content-Type': 'application/json',
-        'Idempotency-key': data.idempotencyKey,
-      },
+      headers,
       body: JSON.stringify({
         reference_id: data.referenceID,
         payment_method_id: data.paymentMethodID,
@@ -28,6 +33,8 @@ function createDirectDebitPayment(data) {
         enable_otp: data.enableOTP,
         description: data.description,
         device: data.channelCode === 'BCA_ONEKLIK' ? data.device : undefined,
+        success_redirect_url: data.successRedirectUrl,
+        failure_redirect_url: data.failureRedirectUrl,
         basket: data.basket
           ? data.basket.map(product => ({
               reference_id: product.referenceID,
@@ -56,14 +63,19 @@ function validateOTPforPayment(data) {
     const compulsoryFields = ['directDebitID', 'otpCode'];
     Validate.rejectOnMissingFields(compulsoryFields, data, reject);
 
+    const headers = {
+      Authorization: Auth.basicAuthHeader(this.opts.secretKey),
+      'Content-Type': 'application/json',
+    };
+    if (data.apiVersion !== null) {
+      headers['Api-Version'] = data.apiVersion;
+    }
+
     fetchWithHTTPErr(
       `${this.API_ENDPOINT}/direct_debits/${data.directDebitID}/validate_otp/`,
       {
         method: 'POST',
-        headers: {
-          Authorization: Auth.basicAuthHeader(this.opts.secretKey),
-          'Content-Type': 'application/json',
-        },
+        headers,
         body: JSON.stringify({
           otp_code: data.otpCode,
         }),

diff --git a/src/direct_debit/payment_method.js b/src/direct_debit/payment_method.js
@@ -16,6 +16,7 @@ function createPaymentMethod(data) {
         type: data.type,
         properties: {
           id: data.properties.id,
+          channel_code: data.properties.channelCode,
         },
         metadata: data.metadata,
       }),

diff --git a/src/ewallet/payment_method.d.ts b/src/ewallet/payment_method.d.ts
@@ -3,7 +3,8 @@ enum PaymentMethodType {
 }
 
 interface PaymentMethodProperties {
-  id: string;
+  id?: string;
+  channelCode?: string;
 }
 
 export function createPaymentMethod(data: {