[NYS2AWS-143] make cluster issuer optional #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS-related problem: if you want to use self-signed certificates with your ALB load balancer (which is the case with OTI/DSNY), you need to add the certificate to AWS' Certificate Manager. You don't need to add the certificate as a K8S resource separately.
Problem: if you set the cluster issuer on the Ingress resource to some value, a certificate is automatically created, even if the issuer does not exist. The certificate never gets ready, though.
Solution: make the cluster issuer optional, but default to
letsencrypt-productionfor compatibility reasons.