IH-416: EXT4 for Dom0 Root & Logs Partitions #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldEV
requested review from
rosslagerwall,
freddy77,
alexbrett,
ashwin9390 and
bernhardkaindl
bernhardkaindl
previously approved these changes
Aug 30, 2024
ashwin9390
approved these changes
Sep 12, 2024
ashwin9390
previously approved these changes
Sep 12, 2024
freddy77
reviewed
Sep 13, 2024
freddy77
reviewed
Sep 13, 2024
freddy77
reviewed
Sep 13, 2024
GeraldEV
dismissed stale reviews from ashwin9390 and bernhardkaindl
via
37212d8
|
Latest commits address comments from the review, happy to squash when everyone has had a chance to check the diff |
bernhardkaindl
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
@GeraldEV Thanks!
@freddy77 @ashwin9390: It should be easy for you to review the diff (== commit 4)!
The changes are minimal and only what has been asked in the review.
I should mention that @GeraldEV mentioned in the description that this depends on #161, which also needed one more review (but that's done also now!).
ashwin9390
approved these changes
Oct 4, 2024
freddy77
approved these changes
Oct 29, 2024
added 2 commits
October 30, 2024 11:41
Add support for answerfile control over root & logs filesystem type. Only EXT3 and EXT4 are available and the functionality is declared unsupported.
GeraldEV
force-pushed
the
private/geralde/IH-416
branch
from
37212d8 to
fa18fb6
Compare
|
Squashed the review comments commit, merging! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for EXT4 root and logs partitions on fresh install and upgrade.
Backup and restore is handled by checking the type of the partition being backed-up/restored-to instead of assuming it's EXT3.
This change is intentionally undocumented in doc/answerfile.txt as we are not expecting to support environments which intentionally divert from the default fs type.
This has been tested manually in all ext3/ext4 combinations (e.g. from ext3->ext3, ext3->ext4, etc.) in fresh installs, upgrades, and restores.
A regression test is being introduced into XenRT, see jobs 4087565 & 4088336 and XenRT PR XXX
This PR depends on commit e72687b from #161
For XenServer internal, see PRs:
grub.spec - PR 23
host-upgrade-plugin - PR 42
XenRT - PR 10192