Skip to content
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

Remove preconfigured yum repos as last step of build #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarkSymsCtx
Copy link
Collaborator

Avoid unexpected fallback by removing all yum repos and require the build process to add them

Signed-off-by: Mark Syms [email protected]

@MarkSymsCtx MarkSymsCtx requested a review from euanh May 16, 2017 09:00
@euanh euanh requested a review from srowe August 22, 2017 09:35
Copy link
Contributor

@euanh euanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to mark them disabled, so they are still there if someone wants to install a utility package in at run time?

@MarkSymsCtx
Copy link
Collaborator Author

We add our own repos from artifactory in the build process, we want those to be preferred and they should have everything needed.

@euanh
Copy link
Contributor

euanh commented Aug 22, 2017

Yes, but we also use these containers for local builds, and being able to say yum --enablerepo=base install <foo> is very useful in that case.

@MarkSymsCtx
Copy link
Collaborator Author

We have to avoid the names clashing then. Probably needs an update to the Jenkins build jobs to prefix or suffix the repo names before merging this

@mseri
Copy link
Contributor

mseri commented Aug 22, 2017

I think an issue here may be that the internal centos images are already using the correct snapshoted repositories, while the upstream centos is not

@mseri
Copy link
Contributor

mseri commented Feb 9, 2018

@MarkSymsCtx @euanh Should we close or merge this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants