Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore coverage upload to codecov (falls back to legacy uploader), add coveralls upload #71

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Feb 13, 2024

Two commits here:

  • they don't overlap the same lines
  • They make their change twice because we upload coverage with the python2.7 and python3. to coverage databases (coverity.io / coveralls.io)
  • they only alternate within the same file

The commits are:

@bernhardkaindl bernhardkaindl changed the title Coverage codecov use cli otherwise legacy Restore coverage upload to codecov (falls back to legacy uploader), add coveralls upload Feb 13, 2024
@bernhardkaindl bernhardkaindl force-pushed the coverage-codecov-use-cli-otherwise-legacy branch 2 times, most recently from e732fbb to fb67085 Compare February 14, 2024 01:14
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb9a639) 85.55% compared to head (01fc023) 86.95%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   85.55%   86.95%   +1.39%     
==========================================
  Files          16       17       +1     
  Lines        2021     2138     +117     
==========================================
+ Hits         1729     1859     +130     
+ Misses        292      279      -13     
Flag Coverage Δ
python2.7 85.57% <100.00%> (+1.51%) ⬆️
python3.10.13 86.28% <100.00%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bernhardkaindl bernhardkaindl force-pushed the coverage-codecov-use-cli-otherwise-legacy branch 8 times, most recently from b374d3c to c1d531f Compare February 14, 2024 19:02
@bernhardkaindl bernhardkaindl force-pushed the coverage-codecov-use-cli-otherwise-legacy branch from c1d531f to 01fc023 Compare February 14, 2024 19:03
@bernhardkaindl bernhardkaindl force-pushed the coverage-codecov-use-cli-otherwise-legacy branch from 01fc023 to d1cae7e Compare February 14, 2024 19:29
@bernhardkaindl bernhardkaindl merged commit 9474235 into xenserver:master Feb 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants