CP-48196: Add a unit-test for dump_xapi_subprocess_info()
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 88.29% 90.09% +1.79%
==========================================
Files 18 19 +1
Lines 2196 2210 +14
==========================================
+ Hits 1939 1991 +52
+ Misses 257 219 -38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 8061800114Details
💛 - Coveralls |
Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
unit_test-dump_xapi_subprocess_info
branch
from
fa1eb64 to
f7e5bb2
Compare
bernhardkaindl
added
good first issue
GeraldEV
previously approved these changes
Feb 26, 2024
bernhardkaindl
changed the title
dump_xapi_subprocess_info()dump_xapi_subprocess_info()
bernhardkaindl
changed the title
dump_xapi_subprocess_info()dump_xapi_subprocess_info()
ashwin9390
approved these changes
Feb 27, 2024
ashwin9390
previously approved these changes
Feb 27, 2024
bernhardkaindl
dismissed stale reviews from ashwin9390 and GeraldEV
via
c258113
bernhardkaindl
commented
Feb 27, 2024
ashwin9390
approved these changes
Feb 27, 2024
GeraldEV
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unit-test for
dump_xapi_subprocess_info()which covers all lines of the function:https://app.codecov.io/gh/xenserver/status-report/pull/85/indirect-changes