CA-389177: Fix yes/no input for Python2/XS8: revert to raw_input() on Python2 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8020102376Details
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 88.29% 88.29%
=======================================
Files 18 18
Lines 2195 2196 +1
=======================================
+ Hits 1938 1939 +1
Misses 257 257
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bernhardkaindl
force-pushed
the
fix-yesno-input-for-py2-xs8
branch
from
31f1537 to
3120459
Compare
Python2 `input()` is eqivalent to: `eval(raw_input())`, but we need the raw_input() function in Python2, revert back to it. For reading unqoute strings like `y` without "quotes" from stdin, we need to use `raw_input()` on Python2. Signed-off-by: Bernhard Kaindl <[email protected]>
ashwin9390
previously approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Documentation for this change :https://codeql.github.com/codeql-query-help/python/py-use-of-input/
psafont
reviewed
Feb 23, 2024
bernhardkaindl
force-pushed
the
fix-yesno-input-for-py2-xs8
branch
from
3120459 to
d0e569d
Compare
psafont
approved these changes
Feb 23, 2024
ashwin9390
approved these changes
Feb 23, 2024
bernhardkaindl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python2
input()is eqivalent to:eval(raw_input()), which was wrong for Python2. Fix it.For reading input lines like
y(without "quotes") from stdin, we need to useraw_input()on Python2.AshwinH contributed this comment in his approval:
Documentation for this change :https://codeql.github.com/codeql-query-help/python/py-use-of-input/