Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook to check if the current branch needs rebase #89

Merged

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Feb 27, 2024

Add pre-commit hook to check if the current branch needs rebase

  • GitHub runs CI on the PR branch rebased to the target branch if possible.
  • To avoid hard side effects from working on the branch that is behind the target, warn about it.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #89 (896c7c7) into master (d0e569d) will increase coverage by 1%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##           master    #89   +/-   ##
=====================================
+ Coverage      88%    90%   +1%     
=====================================
  Files          18     19    +1     
  Lines        2196   2210   +14     
=====================================
+ Hits         1939   1991   +52     
+ Misses        257    219   -38     

see 1 file with indirect coverage changes

Flag Coverage Δ
python2.7 88% <ø> (+1%) ⬆️
python3.10.13 89% <ø> (+1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@coveralls
Copy link

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8249850420

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on check_if_branch-needs-rebase at 92.479%

Totals Coverage Status
Change from base Build 8233068102: 92.5%
Covered Lines: 2115
Relevant Lines: 2287

💛 - Coveralls

@bernhardkaindl bernhardkaindl force-pushed the check_if_branch-needs-rebase branch from b636fba to 829f1ca Compare February 27, 2024 17:42
@bernhardkaindl bernhardkaindl force-pushed the check_if_branch-needs-rebase branch 2 times, most recently from 4814fda to 896c7c7 Compare March 12, 2024 13:40
@bernhardkaindl bernhardkaindl requested a review from GeraldEV March 12, 2024 13:44
@bernhardkaindl
Copy link
Collaborator Author

@GeraldEV Thanks for the review!

Thanks for hinting me at the log() call and the comment!

I updated both, fixing them and moved the comment and added missing comments as well!

@bernhardkaindl bernhardkaindl merged commit 1461413 into xenserver:master Mar 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants