Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline popup editor background fix #3562

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

Ryanseanlee
Copy link
Contributor

@Ryanseanlee Ryanseanlee commented Jan 12, 2024

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@Ryanseanlee
Copy link
Contributor Author

Screenshot 2024-01-11 at 4 38 39 PM

This is what is currently happening when in dark mode.

I am not sure if this is the exact fix we want but this will give the popover a background

@lbwexler lbwexler requested a review from TomTirapani January 12, 2024 00:52
@TomTirapani
Copy link
Member

Thanks Ryan, this looks great! The CSS certainly looks like we're targetting the right selector and fixing the problem... however, I would recommend we use var(--xh-grid-bg); so it looks more part of the grid. var(--xh-popup-bg); default gray looks a bit like a disabled field to my eyes.

@TomTirapani TomTirapani merged commit 76105ed into develop Jan 17, 2024
2 checks passed
@TomTirapani TomTirapani deleted the inlinePopupEditorBackgroundFix branch January 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants