Remove -Werror, I only ensure it can be no warnings on msvc

Fix Unsafe.set buggy
xia-mc · Nov 13, 2024 · b63cb90 · b63cb90
1 parent ad10549
commit b63cb90
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/pyfastutil/src/ints/IntArrayList.h b/pyfastutil/src/ints/IntArrayList.h
@@ -6,7 +6,6 @@
 #define PYFASTUTIL_INTARRAYLIST_H
 
 #include "utils/PythonPCH.h"
-#include "Compat.h"
 
 PyMODINIT_FUNC PyInit_IntArrayList();
 

diff --git a/pyfastutil/src/unsafe/Unsafe.cpp b/pyfastutil/src/unsafe/Unsafe.cpp
@@ -116,7 +116,7 @@ static PyObject *Unsafe_set([[maybe_unused]] PyObject *self, PyObject *args) {
     }
 
     const Py_ssize_t pySize = PyBytes_Size(pyBytes);
-    if (pySize == -1 || pySize > static_cast<Py_ssize_t>(SIZE_MAX)) {
+    if (pySize == -1 || pySize > SIZE_MAX) {
         PyErr_SetString(PyExc_TypeError, "Invalid bytes.");
         return nullptr;
     }

diff --git a/pyfastutil/src/unsafe/Unsafe.h b/pyfastutil/src/unsafe/Unsafe.h
@@ -6,7 +6,6 @@
 #define PYFASTUTIL_UNSAFE_H
 
 #include "utils/PythonPCH.h"
-#include "Compat.h"
 
 PyMODINIT_FUNC PyInit_Unsafe();
 

diff --git a/setup.py b/setup.py
@@ -19,7 +19,7 @@
     # Unix-like uses GCC/Clang
     EXTRA_COMPILE_ARG = [
         "-O3", "-funroll-loops", "-flto", "-fPIC",
-        "-std=c++2b", "-Wall", "-Werror", "-fvisibility=hidden",
+        "-std=c++2b", "-Wall", "-fvisibility=hidden",
         "-Wno-error=unknown-pragmas",
         "-Wno-error=unguarded-availability-new"  # already handle in Compat.h
     ]